Page History

...

	Description	Bad	Good
1	Don't forget to check the copyright (add/modify new calendar year to existing copyright if needed)		`* Copyright (C) 2021 Other Company` `* Modifications Copyright (C) 2021-2022 Nordix Foundation`
2	Don't forget to check the commit message structure		It is following ONAP commit message guidelines: Commit Messages#CommitStructure
3	Overuse of constant for String Literals (that don't add value) Also duplication is not a good reason, it often 'smells like' a method that should be extracted out instead	`final static String HELLO = "Hello ";` `String message = HELLO + name;`	`String message = "Hello " + name;` `String sayHello(final String name) { return "Hello " + name; }`
4	Avoid using ! when else block is implemented	`if (x!=null) {` `do something; } else { report error; }`	`if (x==null) { report error; } else { do something; }`
5	No need for else after return statement	`if (x==true) {` `return something; } else { return something-else;}`	`if (x==true) {` `return something; } return something-else;`
6	No need to check for not empty before iterating on collection	`if (!myCollection.isEmpty) {` `collection.forEach(some action); }`	`collection.forEach(some action);`
7	No unnecessary test data

Groovy & Spock Conventions

...