Versions Compared

Old Version 8

changes.mady.by.user Luke Gleeson

Saved on

compared with

New Version 9

changes.mady.by.user Luke Gleeson

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

FixNameDescriptionCost/MaintainabilityAgnostic of database technologySeparation of NCMP Data

Upgradability/

Rollback

Additional Pros/ConsOne instance does initialisation
1Liquibase init container
  1. Add init container to oom
    1. Restart issues are only happening with kubernetes restarting liquibase
  2. Add "depends on" container to cps
    1. cps standalone deployment is not effected by kubernetes issue
  1. Double changelog dependency? one in oom, one in cps
  2. Changes to oom and cps projects
Yes including Neo4JIs possible but needs some refactoring (Labeling)Good

Good control of database versioning

Yes
2Change/Add liveness probes?Liquibase container is restarted by Kubernetes as it does not read a readiness probe within a certain amount of time. We could extend the time limit, change the restart condition etc... 
  1. Timing updates
  2. Changes to oom only
No changeNo changeGood
Yes
3Start up probe?Using the start up probe we can define a worst case start up time which kubernetes will wait for before restarting the container
  1. Timing updates
  2. Changes to oom only
No changeNo changeGood
Yes
4Remove Liquibase and replace with similar technologyReplace Liquibase with Flyway
  1. Migrate from Liquibase 
  2. Flyway only does sql changelogs, would have to change from yaml > sql

Flyway does not support NoSQL: Neo4J

PossibleGood

Would solve 

Jira
serverONAP Jira
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverId425b2b0a-557c-3c0c-b515-579789cceedb
keyCPS-963

Might come with same issue as Liquibase as is more of a Kubernetes issue?

Yes
5

Use cps-core API

Trigger code/script triggered by springboot that will persist the required data
  1. Migrate from Liquibase 
Yes including Neo4JEasyRequires some code

Would solve 

Jira
serverONAP Jira
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverId425b2b0a-557c-3c0c-b515-579789cceedb
keyCPS-963

Do we need database migration technologies? Rollback etc

Yes
6Use Session lock instead of transaction lock for Liquibase

https://mvnrepository.com/artifact/com.github.blagerweij/liquibase-sessionlock/1.2.5

Changeloglock will be dropped once session is dropped by Liquibase container

  1. No change
Yes including Neo4JIs possible but needs some refactoring (Labeling)Good
  1. Depends on privately owned 3pp
  2. Doesn't stop kubernetes from restarting the container, just makes it so that the changeloglock will not be retained. 
No
7Execute Liquibase logic in Spring Boot Service Start Up

Solution 3: https://localcoder.org/how-to-solve-liquibase-waiting-for-changelog-lock-problem-in-several-pods-in-ope

https://docs.spring.io/spring-boot/docs/current/reference/html/howto.html#howto.data-initialization.migration-tool.liquibase

Liquibase start up is contained within CPS start up so can avoid kubernetes Liquibase setup

  1. Change to how Liquibase is started
Yes including Neo4JIs possible but needs some refactoring (Labeling)Good

Springboot supported solution

Yes
8Pre stop hook?Remove Changeloglock before CPS container restart occurs
  1. No change
Yes including Neo4JIs possible but needs some refactoring (Labeling)Good
  1. Doesn't stop kubernetes from restarting the container, just makes it so that the changeloglock will not be retained. 
No
9Move liveness probes before liquibaseStart the liveness probes before Liquibase starts 
  1. No change
Yes including Neo4JIs possible but needs some refactoring (Labeling)Good


Yes

...