Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Note : dmi-plugin is able to handle only 5-8 cm handle per seconds concurrently.

my method (
Test Environment

Secs Taken for

ModuleSyncWatchdog (Cm Handle moves ADVISED->READY)

Secs taken for
Registration sub-process
Commit idParrealel Request to DMIMain improvementComments

Ericsson Testing cluster (with Model adapter that is implementation of dmi-plugin)

Total 1458 cm Handles

6,998 → 0.20/sec2,278 → 0.64/sec

1410509e33142c0c79ff0e111c63abc47f5936d3

https://gerrit.onap.org/r/gitweb?p=cps.git;a=commit;h=1410509e33142c0c79ff0e111c63abc47f5936d3

N/A (1)N/ABaseline as per the bug
600 → 2.43/sec70 → 20.82/sec

c3596fe3a85381668598c75a1ffee4bf973a8518

https://gerrit.onap.org/r/c/cps/+/129829/5

N/A (1)
  1. Created a dedicated threadpool for scheduler. - Tuned async threadpool of notification executor from setting RejectedExecutionHandler and application.yml.

Note : Root cause : We have 3 watchdogs (2 @Scheduled into module sync and 1 into data sync) that was blocking each other as all @Scheduled methods share a single thread by default. )


540 → 2.70 /sec88(?!) → 16.57/sec

6e97bc6ee9f1cb2722aafc42325918e98da5cff2

https://gerrit.onap.org/r/c/cps/+/130058

N/A (1)
  1. Mapped additional properties of YangModelCmHandle.
  2. @Async : scheduler are executing tasks asynchronously 

TBATBA

e367b520ac01432715b701af6e2bd75d4f81bccf

https://gerrit.onap.org/r/c/cps/+/130148 (Latest)

30 (TBC)

1. Introduced timeout for connect and reading for RestTemplate while connecting dmi-plugin.

2. Modified data structure of moduleSyncSemaphore to hold YangModelCmHandle referance (cm handle id) as key of map

3. Working of Modulewatchdog is modified with parallelism and broken into async tasks.

4. ModuleSyncSemaphoreMap is now populated with advised cm handles and processed by Modulewatchdog by batch size (Dynamic batch size at cm registration).

5. Introduled parallelism level for async tasks that are suppiled.

6. Includes cm handle registration preformance code change.

7. Performance Improvement: Postgres Pool Configuration

8. Performance Improvement: Async Notification Pool Configuration.

9. Performance Improvement: Save/update batch of CM-Handle States in one operation.

10. Performance Improvement: Updating (many) child datanodes/datanode tree into one SQL operation

11. Performance Improvement: Native query to more efficiently get all yangResourceIds.

12. Performance Improvement: Detaching fragment entities early.

13. Performance Improvement: Decouple Temporal DB Notification from main thread.

Note : It includes bottleneck of in my recursive method (Joseph Keenan is working on it to improve.

org.onap.cps.spi.impl.CpsDataPersistenceServiceImpl#toDataNode)

Unable to capture performance result as Module adapter is not able to  handle concurrent requests(Csaba is working on fix)

Local Development Machine with CSIT docker deployment (with dmi-plugin that is  implemented by CPS team) 

Note : dmi-plugin is able to handle only 5-8 cm handle per seconds concurrently.

240 → 6.08 /sec30 → 48.6/ sec

e482e74e2dab8455d0642829005c03212936b73d

https://gerrit.onap.org/r/c/cps/+/130148

30
  1. Data structure of moduleSyncSemaphore to hold YangModelCmHandle object as key of map that was eliminates the call of org.onap.cps.spi.impl.CpsDataPersistenceServiceImpl#toDataNode and reduced 404 seconds (to fetch 1500 cm handles).


Note : As a team we decided to not to store YangModelCmHandle object as key of map as cache. 



Local Development Machine with CSIT docker deployment (with dmi-plugin that is  implemented by CPS team) 


Get ADVISED cm handles +  ADVISED to READY 





97+296 = 393 → 3.81 / sec

30 → 48.6

246 +356 = 602 → 2.49/sec

Note : 246 sec to fetch 1500 advised cm handles (It includes bottleneck of in my recursive method : org.onap.cps.spi.impl.CpsDataPersistenceServiceImpl#toDataNode)

31 → 48.39 / sec


e367b520ac01432715b701af6e2bd75d4f81bccf

https://gerrit.onap.org/r/c/cps/+/130148  (Latest)

305

Removed  YangModelCmHandle object as key of map and stores only the reference that is cm handle id.



Note :

  1. It includes bottleneck of in
  1. recursive
  1. method 

 (org.onap.cps.spi.impl.CpsDataPersistenceServiceImpl#toDataNode)Joseph Keenan is working on it to improve.

   2. dmi-plugin is able to handle only 5-8 cm handle per seconds             concurrently.

125+378  = 503 → 2.98  / sec33 → 45.45 / sec10

246 +356 = 602 → 2.49 / sec


31 → 48.39 / sec30(org.onap.cps.spi.impl.CpsDataPersistenceServiceImpl#toDataNode)

Test Configuration 

Use Case

...