In addition to the guidelines specified . . . specified Committer Best Practices, all DCAE committers are expected to look at these areas before merging a patch. If any item is not followed, you should reply with a -1 and . Also add comments in appropriate places within the code.
...
- Most importantly, does it actually fix what the commitment message says should be fixed?
- Verify against ONAP code standards found . . .
- Java style is specified here, which points to the Google Style Guide repo.
- Javascript code should meet the similar Javascript Google Style Guide, except for the number of characters in one line of code is not restricted.
- Python code should similarly match the Python Google Style Guide.
Check whether the version number should be updated
- if there is any new feature/enhancement
- the patch version should be bumped
- if a change is a bugfix on prev a previously merged patch, AND if the prevous that previous version is not already released
- then version change is optional
- different repos need to have the version number expressed in multiple places
- document those . . .
Were there any -1 on previous patches by another committer or the PTL?
- This is a FULL STOP.
- Please DO NOT merge the code until:
- that other committer has given at least a subsequent +1 or
- the PTL says it is okay to +2 anyway (which would be very rare)