Versions Compared

Old Version 3

changes.mady.by.user Tony Hansen

Saved on

compared with

New Version 4

changes.mady.by.user Vijay Venkatesh Kumar

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: self release and review

...

  • is there a LICENSE.txt file?
  • All code modules should have comments at the beginning that look like:

# ================================================================================
# Copyright (c) 2017-2020 Company1. All rights reserved.
# Copyright (c) 2020 Company2. All rights reserved.
# Copyright (c) 2020 Company3. All rights reserved.
# ================================================================================
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ============LICENSE_END=========================================================

  • All documentation files should have comments at the beginning that look like:

.. This work is licensed under a Creative Commons Attribution 4.0 International License.
.. http://creativecommons.org/licenses/by/4.0
.. Copyright (c) 2017-2020 Company1. All rights reserved.

  • Does it mention the current year for the company doing the modification?
  • Note that there is no separator between Copyright lines by different companies.
  • Note that when a company updates code that was previously copyrighted by them, the date range should be extended as shown.
  • There is no alternate wording for the copyright lines, such as "modifications copyright"

...

  • This is a FULL STOP.
  • Please DO NOT merge the code until:
    • that other committer has given at least a subsequent +1 or
    • the PTL says it is okay to +2 anyway (which would be very rare)

Self-Release yaml 

  • Ensure no outstanding patch remaining in gerrit for review/merge 
  • As artifiact release impacts different repositories (blueprint/bootstrap, oom etc); consolidate release request (and subsequent update to other impacted repositories)

Review window of atleast 1 day

  • Avoid same day approval unless change is fixing an broken job or critical bug 
  • As committers are spread across different timezone, provide atleast 24 hours window before merge for non-critical updates.
  • Include other committers and contributors for repository for reviews