Page History

...

Most importantly, does it actually fix what the commitment message says should be fixed?
Verify against ONAP code standards.
- Java style is specified here, which points to the Google Style Guide repo.
- Javascript code should meet the similar Javascript Google Style Guide, except for the number of characters in one line of code is not restricted.
- Python code should similarly match the Python Google Style Guide.
Did the unit tests get updated?
- New functionality MUST have unit tests.
- New methods added to existing code MUST be covered by existing or additional unit tests.
- We are looking for a minimum of 60% code coverage, with higher levels encouraged.

Check whether the version number should be updated

...

if a change is a bugfix on a previously merged patch, AND if that previous version is not already released
- then version change is optional
different repos need to have the version number expressed in multiple places
- TBD: document those . . . TBD

Errors during the build process will cause the verify step to post a -1, preventing merger.
However, there are a other things to still look for in the build console output.
- In java and python code, does the "lint" pass look okay?
- Look for "hidden pieces of coal". Lots of stylistic issues (say about indentation and white space) can hide real issues.
Are the unit tests running cleanly?
- For example, you shouldn't see stack traces from unit tests, as the unit tests should capture those.
Check the code coverage statistics when available.
- Python code will generally show code coverage statistics in the build console output.
- Make certain that we don't fall below 60% code coverage. (Numbers closer to 80% are encouraged.)
- Java code usually does not show in out build logs, but instead are generated after merger.

...