...
- Errors during the build process will cause the verify step to post a -1, preventing merger.
- However, there are a other things to still look for in the build console output.
- In java and python code, does the "lint" pass look okay?
- Look for "hidden pieces of coal". Lots of stylistic issues (say about indentation and white space) can hide real issues.
- Are the unit tests running cleanly?
- For example, you shouldn't see stack traces from unit tests, as the unit tests should capture those.
- Check the code coverage statistics when available.
- Python code will generally show code coverage statistics in the build console output.
- Make certain that we don't fall below 60% code coverage. (Numbers closer to 80% are encouraged.)
- Java code usually does not show in out build logs, but instead are currently generated after merger.
Were there any -1 on previous patches by another committer or the PTL?
...