Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Merge 2 'query' end points in one

#LayerProposed Changes
1Cps service Layer
  1. Create a new CpsAdminNotFoundException class, child of CpsAdminException class
  2. Add CpsAdminNotFoundException as parent for all "NotFound" exceptions:
    1. AnchorNotFoundException
    2. DataNodeNotFoundException
    3. DataspaceNotFoundException
    4. ModuleNamesNotFoundException
    5. SchemaSetNotFoundException
2Controller Layer
  1.  NetworkCmProxyRestExceptionHandler
    1. create a new @ExceptionHandler for the new CpsAdminNotFoundException 
    2. return with 404 error code
3Test
  1. In Cps service Layer we have tests for this exceptions (CpsAdminPersistenceServiceSpec)
  2. Add new test to the REST handler tests (NetworkCmProxyRestExceptionHandlerSpec)


  1. Catch the exception in query side and return with empty list
  2. 200 OK response code with right body with empty data.