...
- Most importantly, does it actually fix what the commitment message says should be fixed?
- Verify against ONAP code standards. In general, we use the Google Style Guide with some small modifications.
- Java style is specified here, which points to the Google Style Guide repo, but with indentation level of 4 and a column limit of 120.
- Javascript code should meet the similar Javascript Google Style Guide, except for the number of characters in one line of code is not restricted.
- Python code should similarly match the Python Google Style Guide, but with a column limit of 120.
- C++ and C code should similarly match the C++ Google Style Guide, but with a column limit of 120.
- Did the unit tests get updated?
- New functionality MUST have unit tests.
- New methods added to existing code MUST be covered by existing or additional unit tests.
- We are looking for a minimum of 60% code coverage, with higher levels encouraged.
- Using the knowledge of Security design principles, does the code meet the security requirement and not introduce any vulnerabilities.
- Verify that no non-encrypted credentials (non-test) are stored in the repositories
Check whether the version number should be updated
...