Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents
outlinetrue

Community contributors are managed by selected team members from the CPS project

Contact: Lee Anjella Macabuhay Priyank Maheshwari 

...

In order for the CPS team to regularly review the code commits from external contributors the following process and rotational schedule is created. 

  • Note to reviewers: Once you start reviewing a code, it is expected that you review this code as neccessary until code is merged.

Current rotation period: 2 weeks

...

 

...

...

 

...

...

 

...

...

...

...

...

...

 

...

Code review process

  1. Members of the community shall submit their code as work in progress (WIP) initially on gerrit.Image Added
  2. Always do a self-review first and use the CPS Code Review Check List to minimize the number of peer review iterations required!
  3. CPS team member that manages the team will do an initial review and once done with a +1 - the code submitter can then change the status to active.Image Added
  4. Once active, then selected team members based on the review scheduleof the CPS project can review the code. 



Relevant tools

Slack - slack channel is used to coordinate between the community and the CPS team members regarding the code reviews. Contact Lee Anjella Macabuhay  to be added.

Review Schedule (TechMahindra)


#Epic (Jira)Topic (part)First Line ReviewersSenior Approver
1

Jira
serverONAP Jira
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverId425b2b0a-557c-3c0c-b515-579789cceedb
keyCPS-1632

Enhancing CPS CORE API
2

Jira
serverONAP Jira
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverId425b2b0a-557c-3c0c-b515-579789cceedb
keyCPS-1630

Support for top-level data nodes
3

Jira
serverONAP Jira
columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverId425b2b0a-557c-3c0c-b515-579789cceedb
keyCPS-1752

CPS Delta Feature
4

Jira
serverONAP Jira
serverId425b2b0a-557c-3c0c-b515-579789cceedb
keyCPS-1605

Pagination

Community Contributors

TeamContributorsNotes

External Contributors

TeamContributors
Deutsche Telekom (TechMahindra)

Deutsche Telekom (TechMahindra) Team Calendar

Capegemini Team ( 5G SON Use Case )Vishal Varvate  murali parthasarathy k 

...