...
| Scenario | Endpoint | Current Response Code | Proposed Response Code | Comments |
|---|---|---|---|---|
| Create CM Handle | POST /v1/ch | 201 (Created)200 | 204 ( OK NO_CONTENT ) | |
| Update CM Handle | POST /v1/ch | 201 (Created) 200 | 204 ( OK NO_CONTENT ) | |
| Remove CM Handle | POST /v1/ch | 201 (Created) 200 | 204 ( OK NO_CONTENT ) | |
| Create ,Update or Remove CM Handle in the same request | POST /v1/ch | 201 (Created) 200 | 204 ( OK NO_CONTENT ) |
As we are using a common payload to handle the Create , Update and Remove operation hence there is a need to streamline the response code in case of successful execution of the request.
...
| Code Block | ||||||
|---|---|---|---|---|---|---|
| ||||||
@Override
public ResponseEntity<Void> updateDmiPluginRegistration(
final @Valid RestDmiPluginRegistration restDmiPluginRegistration) {
final DmiPluginRegistration dmiPluginRegistration = convertRestObjectToJavaApiObject(restDmiPluginRegistration);
networkCmProxyDataService.updateDmiRegistrationAndSyncModule(dmiPluginRegistration);
if (dmiPluginRegistration.getCreatedCmHandles() == null) {
return new ResponseEntity<>(HttpStatus.NO_CONTENT);
}
return new ResponseEntity<>(HttpStatus.OK);
} |