- CPS-892Getting issue details... STATUS
References
CM Handle Registration Request Payload
Proposed Changes
Scenario | Endpoint | Current Response Code | Proposed Response Code | Comments |
---|---|---|---|---|
Create CM Handle | POST /v1/ch | 201 (Created) | 200 ( OK ) | |
Update CM Handle | POST /v1/ch | 201 (Created) | 204 ( NO CONTENT ) | |
Remove CM Handle | POST /v1/ch | 201 (Created) | 204 ( NO CONTENT ) | |
Create ,Update or Remove CM Handle in the same request | POST /v1/ch | 201 (Created) | 200 ( OK ) |
As we are using a common payload to handle the Create , Update and Remove operation hence there is a need to streamline the response code in case of successful execution of the request.
For other scenarios , please refer to the page for the exceptions and response codes which will remain as is.
Code Change
NetworkCmProxyInventoryController
@Override public ResponseEntity<Void> updateDmiPluginRegistration( final @Valid RestDmiPluginRegistration restDmiPluginRegistration) { final DmiPluginRegistration dmiPluginRegistration = convertRestObjectToJavaApiObject(restDmiPluginRegistration); networkCmProxyDataService.updateDmiRegistrationAndSyncModule(dmiPluginRegistration); if (dmiPluginRegistration.getCreatedCmHandles() == null) { return new ResponseEntity<>(HttpStatus.NO_CONTENT); } return new ResponseEntity<>(HttpStatus.OK); }