Developer Environment
- Please setup your development environment according to ONAP guidelines. Doing so eases the review process for the committers and SME's review your submission.
Code Submissions
- All code submissions should not degrade the quality of the policy/* project codebase.
- Any sonar, checkstyle issues must be fixed in the current review or a subsequent review.
- The same JIRA should be used for these submissions.
- API changes most likely will require updates to CSIT tests. It is the responsibility of the contributor to provide a code review to update/enhance the CSIT tests for their contribution.
Java Code Required Practices
The committers have agreed upon these desired preferences for submitting java code. WIP
- JUnit Test file naming WIP ( PLD - I thought we had a page on this??)
Committer Strategy
- Require 3 committers to +1 a review - at least 2 companies represented.
- Require at least one expert of the repo to +1 (may or may not be a committer).
- For substantial reviews, either size or logic changes, then time limit of 24 hours to review can override.
- A +2 from committer or PTL, one can imply they are good with any future patches for a review.