References
- CPS-438Getting issue details... STATUS
Background
cps container attempts restart if it takes too long. Liquibase does not release the changelog lock on the data table if it gets restarted.
Possible Fixes:
Fix | Name | Description | Cost/Maintainability | Agnostic of database technology | Separation of NCMP Data | Upgradability/ Rollback | Additional Pros/Cons | One instance does initialisation |
---|---|---|---|---|---|---|---|---|
1 | Liquibase init container |
|
| Yes including Neo4J | Is possible but needs some refactoring (Labeling) | Good | Good control of database versioning | Yes |
2 | Change/Add liveness probes? | Liquibase container is restarted by Kubernetes as it does not read a readiness probe within a certain amount of time. We could extend the time limit, change the restart condition etc... |
| No change | No change | Good | Yes | |
3 | Start up probe? | Using the start up probe we can define a worst case start up time which kubernetes will wait for before restarting the container |
| No change | No change | Good | Yes | |
4 | Remove Liquibase and replace with similar technology | Replace Liquibase with Flyway |
| Flyway does not support NoSQL: Neo4J | Possible | Good | Yes | |
5 | Use cps-core API | Trigger code/script triggered by springboot that will persist the required data |
| Yes including Neo4J | Easy | Requires some code | Yes | |
6 | Use Session lock instead of transaction lock for Liquibase | https://mvnrepository.com/artifact/com.github.blagerweij/liquibase-sessionlock/1.2.5 Changeloglock will be dropped once session is dropped by Liquibase container |
| Yes including Neo4J | Is possible but needs some refactoring (Labeling) | Good |
| No |
7 | Execute Liquibase logic in Spring Boot Service Start Up | Solution 3: https://localcoder.org/how-to-solve-liquibase-waiting-for-changelog-lock-problem-in-several-pods-in-ope Liquibase start up is contained within CPS start up so can avoid kubernetes Liquibase setup |
| Yes including Neo4J | Is possible but needs some refactoring (Labeling) | Good | Springboot supported solution | Yes |
8 | Pre stop hook? | Remove Changeloglock before CPS container restart occurs |
| Yes including Neo4J | Is possible but needs some refactoring (Labeling) | Good |
| No |
9 | Move liveness probes before liquibase | Start the liveness probes before Liquibase starts |
| Yes including Neo4J | Is possible but needs some refactoring (Labeling) | Good | Yes |