...
Issue | Notes | Decision | |||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | use api and impl folders | Team agreed on separate top level ap and impl folders. Common impl folders can be at top level ie. not under impl. | |||||||||||||||||||||||||||||||||||||||||||||||||
2 | use feature based packages | Team agreed to use the current 4 services (or 5 depending on inventory) as feature folders directly under impl and some also under api and impl
The following feature structure emerged during the actual refactoring
| |||||||||||||||||||||||||||||||||||||||||||||||||
3 | when to use common packages | when in doubt use common package ie e.g. exceptions might be re-used for other features in the future | |||||||||||||||||||||||||||||||||||||||||||||||||
4 | scope | currently only ncmp-service in scope. | |||||||||||||||||||||||||||||||||||||||||||||||||
5 | plan | team agreed to do trial with 'datajobs' first. Code need to be reviewed by both teams. Once this is completed we will asdress address 'legacy' services |
Proposed Generic Structure
...
Code Block | ||
---|---|---|
| ||
api\datajobs\DataJobsService.class api\datajobs\models\DataJobMetadata.class api\datajobs\models\DataJobReadRequest.class api\datajobs\models\DataJobWriteRequest.class impl\datajobs\DataJobsServiceImpl.class exceptions\NoAlternateIdParentFoundException.class utils\AlternateIdMatcher.class |
Proposed User Stories
Jira server ONAP Jira serverId 425b2b0a-557c-3c0c-b515-579789cceedb key CPS-2240 Jira server ONAP Jira serverId 425b2b0a-557c-3c0c-b515-579789cceedb key CPS-2255 Jira server ONAP Jira columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId 425b2b0a-557c-3c0c-b515-579789cceedb key CPS-2256 Jira server ONAP Jira columnIds issuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId 425b2b0a-557c-3c0c-b515-579789cceedb key CPS-2257 Jira server ONAP Jira serverId 425b2b0a-557c-3c0c-b515-579789cceedb key CPS-2258 Jira server ONAP Jira serverId 425b2b0a-557c-3c0c-b515-579789cceedb key CPS-2298