Versions Compared

Old Version 7

changes.mady.by.user Kenny Paul

Saved on

compared with

New Version 8

changes.mady.by.user Joss Armstrong

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Panel
titleCommitter

A Committer is a contributor that has the authority, and responsibility to submit changes to the ONAP software repository.

Typical characteristics of a Committer are:

  1. Deep expertise in the code base over which they are committers
  2. Time dedicated to reviewing code contributions made by other contributors
  3. Knowledge and understanding of the overall development activities occurring within the project - this is important so that the review of new code is taken in the context of the overall development for the project.
  4. Knowledge and understanding of other, interdependent projects within ONAP and how contributions to this project affect work being done elsewhere by others.

The Committers on a project will review each code contribution made by the Contributors, and other Committers on the project. Often, a Committer will need to enter into a dialog with a Contributor to have them make changes to the contribution to better fit the functional, structural makeup or style of the existing codebase. It is preferable to have at least 2 Committers show approval (with a +1) for a contribution before it is accepted into the repository. It is also ideally best practice to never have a Committer review and/or approve their own contribution into the repository except.


Panel
titleProject Technical Lead (PTL)

The PTL is a committer who is the one point of contact responsible for representing the project to the rest of the ONAP community.

For projects that become part of any given release, the PTL is responsible for reporting milestone status and release readiness to the rest of the community. The PTL for each project is elected by the other committers within the project. Please note that it is very common for individuals to be a committer on one project, and an contributor on another. However, there is nothing stopping an individual from being a committer on multiple projects. Also, it is rare, but not unheard of, that an individual can be a PTL on more than one project.

...

  • Committers should not "self merge" their own changes
    refer to

    https://lists.onap.org/pipermail/onap-discuss/2018-February/008068.html

    https://lists.onap.org/pipermail/onap-discuss/2018-February/008181.html

    https://lists.onap.org/pipermail/onap-tsc/2017-May/002341.html

    TSC 2018-03-08


    • Committers should add other committers as reviewers and have at least 2 Committers show approval (with a +1). The first reviewing committer will +1, the second reviewing committer will +2.
    • One exception to the rule is self merging critical changes required to unblock broken builds - maybe.
  • Committers should only merge proposed changes from contributors after at least 2 (+1) reviews.
  • Committers should remove themselves from a review under the following circumstances: 
    • Committer has been added as a reviewer to a change they do not feel comfortable reviewing
    • Committer anticipates a lack of time to review within 1 week 
  • Committers who remove themselves should leave a short comment in the change explaining to the owner the reason for removal
    • This allows owners opportunity to find others willing to review (or to make changes to significantly simplify or further document change)
  • Committers should aim to review all pending changes which have passed verify, have no merge conflicts or (-1) or (-2) reviews in a timely manner. 
  • Committers are welcome to ignore pending changes which do not pass verify, have merge conflicts or have been reviewed (-1) or (-2).
  • Committers should occasionally review the list of all old changes (To be defined). Owners of old changes should be contacted to ascertain if the change can be abandoned. If change owners do not respond or respond that the change has been abandoned, it should be abandoned.

...