Super committers are a group of TSC-approved individuals within the ONAP community with the power to merge patches on behalf of projects during approved Release Activities.
Super committers are still affected by NACR Gerrit rules: https://gerrit-review.googlesource.com/Documentation/prolog-cookbook.html#NonAuthorCodeReview
This means that, even though super committers can +2/submit changes across repos, they will still not be able to bypass this rule for self authored changes.
Super Committer Activities
Super committers are given super committer powers ONLY during TSC-approved activities and are not a power that is active on a regular basis. Once one of the TSC-approved activities are triggered, helpdesk will enable the permissions listed for the respective activities for the duration of that activity.
Code Freeze
This activity has been pre-approved by the TSC and does not require a TSC vote. Helpdesk should be notified to enable the permissions and again to disable the permissions once activities are complete.
Super committers are granted powers to merge blocking patches for the duration code of freeze until a release is approved. This permission is only granted for the specific branch that is to be released.
The following powers are granted:
- +2 Code-Review
- Submit button access
During this time Super Committers can ONLY merge patches that have been validated during E2E testing within the integration lab. The patch passes Jenkins Verify check. If neither of these conditions are met then DO NOT merge the patch. Generally, this should be used for High and Highest priority JIRA tickets that are on the integration blocker list.
Who can be super committers?
Anyone as long as it makes sense for the TSC.
It would seem useful to have super committers in more than one region so that they can help support testing/integration/merge activities across regions/time zones.
The Integration PTL will recommend super committer candidates, get PTL voice vote concurrence vote during a PTL status meeting and recommend the candidates to the TSC for approval
| Approved Super Committers | region / time zone |
Morgan Richomme (Orange) | Central European |
Lukasz Rajewski (Orange) | Central European |
Brian Freeman (AT&T) | NAR (Eastern) |
| Jessica Wagantall (LF Support) | NAR (Pacific) |
| Eric Multanen (Intel) | NAR (Pacific) |
Bin Yang (Windriver) | China |
user-67d6f (Huawei) | India (Bangalore) |
Integration Team committers:
They are validating the ONAP release by running the E2E tests. They raise the bugs, and test their fixes. Giving them the rights to merge the fix would allow them to move faster towards a more sanitized code base.
Doc Team committers:
They are ensuring the documentation is as accurate as possible, by updating project's documentation. Giving them to rights to merge the doc update, they would have the ability to provide better documentation faster.
To request the permissions
- Provide a specific timeline of how long should the permissions be enabled for (Can't be enabled all the time)
- Get TSC approval
- request the permissions to be turned on via support.linuxfoundation.org
Quality checks
Number of patches merged
Number of patches merged that later were found to cause errors
PTL feedback per release cycle