You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 20 Next »

Create 'bulk' version for org.onap.cps.ncmp.rest.controller.NetworkCmProxyController#getResourceDataForCmHandle to support multiple cm-handles (~ multiple anchors in in CPS-Core)

References

CPS-1515 - Spike: Support multiple CM-Handles for NCMP Get Operation

Assumptions

<optional, assumptions are like decision made up front ie. everyone agrees on the answer but they are important to mention>

#

Assumption

Notes

1

"fields" and "scope" are proprietary options or not in the scope of this analysis.


2

same xpath (resourceIdentifierInQuery) for all cm handles or different for each cm handle


Issues & Decisions

#

Issue

Notes 

Decision

1Which operation(s) need support for multiple cm handles?
  1. Get
  2. Create
  3. Update (Put)
  4. Patch
  5. Delete

if many what is the priority?

Get (read)
2

Which datasources should be supported?

Do we need to support passthrough-only no-cached() data only ?
(maybe just start with that, support cached data bulk request later)

passthrough.*

Not implemented for other datastores with respponse code 

3URL  pattern for NCMP bulk endpoints

Existing : /v1/ch/{cm-handle}/data/ds/{datastore-name}

CPS Proposed : /v1/batch/data/ds/{datastore-name}

      ( include cm handles into payload / body and leave datastore into url)


4keep datastore, topic and optional parameters in the URL itself instead into body.

CPS prefers keep interface similar as single cm handle interface (consistency and cost)

Existing : ...&topic=topicParamInQuery


5

support in ONAP DMI-plugin



6

Response always Async ie. topic is compulsory ?

Assume topic is compulsory (defined in OPenApi) → Response therefore wil be 400 if not suppliedYes , Not supported for others
7Should NCMP Amalgamate Async responses from DMI-Plugin before forwarding ?step 6 in flow diagramNo
8Handle non responding dmi-plugin
No response for 4b then send an error response to the topic given by client
9Overlap with Deutsche Telekom

Sourabh Sourabh discussed Lee Anjella Macabuhay who confirmed there s no overlap

No Overlap

<Note. use green for closed issues, yellow for important ones if needed>

Implementation

Bulk Request Message Flow

Cm Handle Batch Interface Design

Message Flow details

Short description

Message Details

Notes

Bulk Get Request

/v1/batch/data/ds/{datastore-name} 
body:
{"Cnhandles":["ch-1",...,"ch-n"]

Define new get operation "getResourceDataForCmHandles" into ncmp.yml

Ack Client Request
Response 200 
{"requestId":"123"}

DMI Bulk Request
url tbd 
body:
tbd

Ack Client Request
Response 202

Kafka Messages from DMI to NCMP
Topic: ncmp-async-m2m 
Message Details TBD

Kafka Message(s) from NCMP to Client 


Topic: <client topic> 
Message Details TBD
see open issue #9
  • No labels