You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 8 Next »

CPS-1733 - Getting issue details... STATUS

CPS-1734 - Getting issue details... STATUS

Study is required to clearly define the scope and impacts of updating YANG model schema sets for cmhandles. 

Requirements

Functional

#InterfaceRequirementAdditional Information
1TBD

Error Handling

#Error ScenarioExpected behavior
1

Capabilities


#ParameterExpectationNotes
1Request Frequency
Upgrade to NEW ModuleSetTags		2.5 upgrades  / second → 150 upgrades / minute

The assumption is there are 100 modules in each moduleSet and a moduleSet is available from a dmi plugin within 0.5 seconds.  Also assume there is a 90% overlap in modules across all CM Handles.

2Request Frequency
Upgrade to already existing ModuleSetTags		5 upgrades  / second → 300 upgrades / minute
3Test Environment
  1. CPS and NCMP

requests:
    cpu: 2000m
    memory: 2Gi
limits:
    memory: 3Gi
    cpu: 3000m

2. Postgres

requests:
    cpu: 4000m
    memory: 1Gi
 limits:
    memory: 3Gi
    cpu: 6000m


4Concurrent requestTBD12 clients requests toward 1 NCMP simultaneously

Out-of-scope

  1. Upgrade of models for cached data (only pass-trough ie. non-cached data upgrade will be supported


Issues & Decisions

#IssueNotes Decision
1Type of Interface REST or KafkaREST
  1. easier/cheaper
  2. possibly (complete) re-use of (inventory) existing interface
  3. well documented by OpenAPI
  4. support test stubs (contract testing)

Kafka

  1. more complicated/costly
  2. plethora of topics and messages, not well documented (no standard)
  3. More robust (request persisted until acknowledged)

Agreed to use REST interface.  

2ModuleSetTag based on Hash no (yet) implemented!

This study seems to assume the module set tag is already implemented but it isn't!


kieran mccarthy :  the request it to introduce the hash for this new usecase.  Not assuming it is there already.  Will be costlier but is important for performance to avoid pulling models if they are already known to NCMP.
3Expected Responses

when and what content?

  1. just acknowledge upon receipt
  2. response on completion

4Should CM-Handle state change (e.g. to 'locked')  'during' upgrade?Yes but is important to not be locked for long which makes it important to use the tag
5ModuleSetTag is Optional (owned and defined by DMI Plugin)Support for upgrade without continues using delete/add cm handle approach.
If the update includes an ModuleSetTag it would be considered an upgrade
6ModuleSetTag should be able to be used during initial inventory too!Initial Inventory should be sped up too (capability requirements impacts ?!)
7Exact name ModuleSetTag

meeting agreed on ModuleSetTag

8How to store: hardcoded (postgress schema), inventory yang model or as additional property (private or public)? update Inventory Yang Model so it can be queried (without code changes!) like other aspect such as 'state'

meeting agreed to update Yang Model


Solution Proposals 

Update Inventory REST Interface

Making the module upgrade request either over REST or Kafka Event with a supplied 'ModuleSetTag' property will indicate to NCMP that a cmhandle has a new moduleSet (node has been upgraded).  The ModuleSetTag is a unique identifier for the set of modules associated with a cmhandle. This event or rest request will trigger ncmp to either retrieve the new module set for this cmhandle from the dmi plugin or if NCMP is already aware of ModuleSetTag as part of a previous retrieval for a set of modules for a cmhandle that supplied this ModuleSetTag then it should not re-retrieve the modules from the dmi plugin as it already has them.  NCMP should use its stored ModuleSetTag to get the set of modules.  It can then do a delta with the existing cmhandle moduleSet and update the moduleSet for the cmhandle.

The above proposal would require model updates to NCMP to store the association between a ModuleSetTag supplied by a dmi-plugin (during and updateCmHandles request) and the modules.  Initially ModuleSetTag is not known to NCMP.  However, after retrieval of the modules for the first time for the cmhandle, NCMP can store the association.  Any subsequent cmhandle that references the same ModuleSetTag will not require NCMP to go back to the dmi plugin for the moduleSet.




Reuse the NCMP Inventory API (CPS-NCMP-I-01). URI : POST /v1/ch

URI: POST /v1/ch requestbody 
{
    upgradedCmHandles : [      
      {
         "cmhandle" : "<cmhandle-id-1>",
         "ModuleSetTag" : "ffsdfg55342"   #  new ModuleSetTag ffsdfg55342 for the cmhandle        },       
      {
         "cmhandle" : "<cmhandle-id-2>",
         "ModuleSetTag" : "ffsdfg55342"   #  new ModuleSetTag ffsdfg55342 for the cmhandle        },     
      { 
         "cmhandle" : "<cmhandle-id-3>",    
         "ModuleSetTag" : "ddger34324"    #  new ModuleSetTag ddger34324 for the cmhandle         }
  ]
}

Support for upgrade without (empty) ModuleSetTag

If the ModuleSetTag json property is set to "" (empty string) or then it should also indicate that the moduleSet for a cmhandle has been updated but there is no associated ModuleSetTag available for that cmhandle.  This approach will always result is a full request to the dmi plugin for the module set for the cmhandle.


  • No labels