Date
Meeting Logistics
Day | Time | Meeting ID | Zoom Link |
Monday | [sdc] Team ONAP3, Mon UTC 10:00 / China 18:00 / Eastern 5:00 / Pacific 02:00 | see list | see ONAP-Meeting invite |
Meeting Attendees
see recording
Agenda & Minutes
Review open action items from last week
Main purpose is to sync between Committers and discuss open reviews, other topics below
Open Reviews :
Agenda | Minutes |
Check on pending Reviews | Any urgent pending reviews ? Discussed several review - Topic : SONAR bugs and coverage, SDC code is not pretty (to say the least) we should remind the community to improve it - do a reminder of the rules (enable checkstyle, sonar checks in IDE) - agree on common rules, maybe enforce them in verify job/add a sonar job in review to catch newly introduced issues quickly - assign resolution to originator of issue since Sept, SDC grow to 145 SONAR bugs AP : Chris to setup a weekly item on items - Done Amir's review, assigned to Julien - Done Seb raised the issue that Log4J 1.2 still identified by NExus IQ as a dependency in Catalog-BE and FE (Chris to look at it) - Fixed by Vasyl |
Discuss UI testing of ONBOARDING | During Weekly call, it was asked if there is a way to configure ONBOARDING UI (react) to allow for localhost startup and direct debug inside the IDE (like IntelliJ). Not clear how the return adresses are configured. Ilana provided a patch, it was tested by Jan but apparently it still has issues, Ilana to have a look Apparently it worked, patch is merged, it was noticed that there is a call twice to the same method that could explain why it failed |
Split verify job in 2 | speed up results by splitting integration phase and unit test/build create new keyword for retest all or only one vote +1 if both are ok mvn clean install -P skip-integration-tests mvn clean install -DskipTests -DskipUICleanup=true -Djacoco.skip=true -DskipPMD -Dmaven.test.skip=true -Dcheckstyle.skip -P docker && mvn install -P start-sdc && mvn install -P run-integration-tests |
Action Items
- Chris to Setup Weekly item on SONAR and remind community about best practice
- All to follow up on reviews
Recording
TBD