Date  

Meeting Logistics

DayTimeMeeting IDZoom LinkJoin by phone
Monday[sdc] Team ONAP3, Mon UTC 11:00 / China 19:00 / Eastern 06:00 / Pacific 03:00https://lists.onap.org/g/onap-meetings/calendarSee Groups.io calendar invite

See Groups.io Calendar Invite

Note that a Waiting room has been added to the meeting room, the host will let you join once identified

Meeting Attendees

TBD - see recording

Agenda & Minutes

Review open action items from last week

AgendaMinutes (Draft to be updated during call)
Slides
Helm package verification

In Guilin, we decided to not do helm package validation/verification, several ideas were discussed at that time. Some improvements are planned for H release.

Presented by Nokia team to discuss how to add Helm validation to SDC onboarding

agreed to :

  • add a new deployed container running the validation service, that can
    • run multiple version of helm and test that the package is deployabe
    • stretch do linting
    • stretch provide feedback to user in SDC UI
  • target H release to add the basic functionality, add configuration data to existing AUTO.JSON loaded in SDC config maps (onboarding container reads this at startup)


Implementation in progress, code is merged on master, need an helm chart update ?


Verify Job split

During the Committer's meeting, we've decided to split SDC verify Job in 2 steps :

1) build + Unit tests (No Docker)

2) build + NO unit tests + Docker + Run integration phase


Change is implemented, note that the jobs run in // but require both to be successful for a merge, the plan is to be able to provide faster feedback

We've reused Integration team new templates for CSIT (job is called Review-Verification Job)

It's enabled only on Master for Now


Note : the Unit test job is failing due to Catalog BE Unit tests, work in progress (any idea welcome)

 - tests are now passing but still a few errors happen from time to time

    npm error when downloading packages

   onap-configuration-core test module is not thread safe (file manipulation)

  a few reviews in progress to try and improve


  • integration tests do fail from time to time in one test case, it seems the UI is hanging when coming back to home screen (then test timeout)


pls recheck if you see one of the failures above, any improvement to fix is welcome


Call for Committers

Requesting active committers to apply for formal Committer's role

Fill the template under : Committer Promotion Request for [SDC]

Will review and request a vote from all current committers


JIRA Updates

  • High priority defects
  • Open Reviews
  • Defects & tasks backlog
  • Others


High priority defects for Honolulu:

 

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Loading...
Refresh

  • Other High priority ticket to discuss ?
  • plan to release 1.8.2 this week with all changes then push to OOM for review

Open Reviews :


New features review / Bug fixes for H release

Similarly for distribution client, should we already deliver a new version ?

Note : SDC CSIT are disabled as tests are done within the SDC verify job, tests that imply only SDC and run on simulators should be run inside the verify job of each project

The CSIT jobs are deprecated for SDC, it would be good to display testing results inside the the jenkins UI (Chris/Seb to check with Jess if feasible - still in progress)

Splitting integraton test and build jobs in progress with CI management jobs


oom reviews:

No review in progress right now (will create one to gate 1.8.1 dockers)


Gerrit REVIEW can proceed with auto test in verify job, now accepting changes for Honolulu

  • Reminder of merge conditions : Verify must pass AND tests must be provided for new features (SONAR metrics are important but can only be checked AFTER code is merged)

Important : for new features, please provide explanation of changes and API/UI/unit testing, it is also advised to present changes at SDC weekly

we have a plan to add SONAR test to the verify job, will work on this in the coming months


Defect & Tasks Backlog (no update this week):

 

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Loading...
Refresh

 

  • Use the AID (Architecture integration documentSDC Data model also for new comers


Others:

Amir status :

Contacted Amir to see if he still is engaged - he seems to be busy with other tasks

Julien working on his Review

Several changes, SnakeYaml is impacting lots of components, review to rebase but passed tests once



3 BP have been approved for H release :

  • up-to-date new dependencies (not transitive) - can contact seccom for guidance
  • Helm V3 (mostly for OOM)
  • CII badging improvements (use good crypto)

2 GR

  • no more use of python2 (deprecated) -#GR
  • java 11 -# GR


Important note to committers and code contributors : please make sure these are followed or your contribution will not be merged




Automated Rolling Upgrade and Data Migration

No Update this release (parking topic for later)


Support of automated upgrade from version X to version X+1


Needed for every change that breaks existing data validity : Have a strategy to handle data migration

  • Create a wiki page, details for every feature and its impact on data for migration / schema changes -  check the wiki page: Upgrade plan
    • Feature X: All services metadata must have new property Y
  • Implementing a "task" for migrating data accordingly.
    • Example: asdctool mig2002

SDC-3155 - Getting issue details... STATUS Epic created

→ Discuss further and create User stories along with Bell Canada, Amdocs, Tata communications

Will need to prioritize VS Guilin Requirements →

this may shift to next release due to low commitment

Learn from SDNC experience;

"Normatives" types: challenging


Important Jira tasks we need to pick up


Long Term tasks

INCREASE SONAR Coverage and lower SONAR bugs

We've noticed a growth of SONAR issues and coverage is getting lower,

https://sonarcloud.io/dashboard?id=onap_sdc

Stats are computed only on Merged code, it would be good for contributors to :

1) Enable Sonar plugins in IDE try to fix issues before they get in

2) To reduce issues, we could try and run through module per module (divide and conquer approach)

3) other ideas ?

4) Coverage call for help to improve and go above 55% :

  • Reduce line of codes (unused code)
  • Increase testing
  • Use LomBok to cover getter setter

Vasyl is proposing a code style improvement (see 3 open reviews in progress)

We should try and vote to decide one to go with, Vote to be organized on SDC-mailing list

Decided to rather go with a Gerrit Vote

Note : I realized that the O-Parent is refering to ONAP guidelines for Checkstyle, maybe we can propose an update to whatever wins our poll

Note : Need to test how gerrit handles > 120lines review in its UI

Not much response, going with 150 line lenght will propose change to the broader ONAP community

   - done on on common, some commits in progress

Other long term tasks

  • SDC-2708 Add assertions for unit tests  - #NewComers
  • SDC-2812Refactor all usage of Eithers - Guilin R7, #NewComers
  • SDC-2844 JUnit 5 unit test  - on going for new UT
  • SDC-3108 - Getting issue details... STATUS Migrate all TestNG tests to Junit5 , #NewComers



Security  - Guilin

Looking at these and this will significantly impact SDC APIs, since SDC does not have password it has to defer request to portal/aaf

exception for this in Guilin requested , though PORTAL provided Credentials validation API so that SDC can check users - will see if we have time to do something about these  

OJSI tickets open on SDC


Basic Auth setup introduced for SDC APIs by Xue, try to be

non breaking to avoid failures, not perfect solution for now, fix for SDC main is merged, but facing issue with WFD (see mail from Xue)

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Loading...
Refresh


Reviewing last week's action items

see below


Q&AIf you have time, pay attention to SDC mailing list questions
Honolulu Requirements

New requirements for H release are now open,

See : Honolulu Release Requirements

and impact per components : Honolulu Impact View per Component


M3 in progress, is planned for the 25th of Feb


Release planning : SDC R8 Release Planning

Please plan to close your Jira tickets


1 POC and 1 REQ without stories



Discuss SDC-3469 and SDC-3433

3433 done

Michael and Andre looking with Rahul

I have seen some commits for this, can we close ?



Action Items ()

  • Chris to report SONAR changes to PTL call : Done, LF is looking to see if we can have a better SONAR Quality profile management (currently relying on SONAR auto profile which are managed by SonarCloud and updated frequently)


Slack Channel : #SDC on LFN ONAP.org Slack instance


IMPORTANT NOTE, Rchat was decommissioned on 2/4, pls use LF Slack


SDC Dev lab on Windriver :

ssh ubuntu@10.12.6.10 (with onap key)

10.12.6.10 - LAb is installed with Guilin → will be reinstalled with WINDRIVER reinstall


Recording


zoom_0.mp4


Chat