Any urgent pending reviews ?

lots of pending review, need to rebase and review code for merge, pls pay attention :

JUNIT version

make sure tests are added (we are low on coverage)

Dependency version must be up to date(TSC must have)

Vasyl asks to review IN/OUT reviews, part 3 will contain tests

in progress

Discussed several review

 - Topic : SONAR bugs and coverage,

    SDC code is not pretty (to say the least) we should remind the community to improve it

    - do a reminder of the rules (enable checkstyle, sonar checks in IDE)

   - agree on common rules, maybe enforce them in verify job/add a sonar job in review to catch newly introduced issues quickly

    - assign resolution to originator of issue

   since Sept, SDC grow to 145 SONAR bugs

  AP : Chris to setup a weekly item on items - Done

Vote on Code style proposal → done

Improve coverage by gathering Integration Test coverage → blocked due to jacoco issue, still at 54.4%

approx 1300 lines more to cover, plan is to improve, Chris to document that for M3

Need to release today to push to oom

2 reviews to merge to be able to do it

André review and delete output

Issue with InvariantUUID that has gone lower case, confirmed by Chris on Windriver lab 10.12.6.10

       Michael has a fix, in toscaexport.java

Increase coverage : again a drop, probably due to disabling nodecli test?

One review is failing integration tests, chris to take a look

speed up results by splitting integration phase and unit test/build

create new keyword for retest all or only one

vote +1 if both are ok

mvn clean install -P skip-integration-tests

mvn clean install -DskipTests -DskipUICleanup=true -Djacoco.skip=true -DskipPMD -Dmaven.test.skip=true -Dcheckstyle.skip -P docker && mvn install -P start-sdc && mvn install -P run-integration-tests

Done, see new verify Jobs

Done for  enabling concurrent builds on integration tests

Still missing : Keyword to re trigger only one, this seems not possible as reusing JJB templates from LF and Integration that are wrapped together → discussed with Lasse, we could try to experiment on our build but since IT tests are the longest, not sure we will will much and the LF wrapper (the one that provides comment and vote +1 ) is probably not smart enough to cope with only one job being re triggered

added more logs for integration-tests

maybe this is failing the review now, chris to check

investigate if job failure can be reported faster (rather than waiting for completion of both jobs, report as soon as one fails)

LF reported they cannot do anything on fail fast, pending response for errorno11 but can be worked around