Date  

Meeting Logistics

DayTimeMeeting IDZoom LinkJoin by phone
Monday[sdc] Team ONAP3, Mon UTC 11:00 / China 19:00 / Eastern 06:00 / Pacific 03:00https://lists.onap.org/g/onap-meetings/calendarSee Groups.io calendar invite

See Groups.io Calendar Invite

Note that a Waiting room has been added to the meeting room, the host will let you join once identified

Meeting Attendees

TBD - see recording

Agenda & Minutes

Review open action items from last week

AgendaMinutes (Draft to be updated during call)
Slides
Helm package verification

In Guilin, we decided to not do helm package validation/verification, several ideas were discussed at that time. Some improvements are planned for H release.

Presented by Nokia team to discuss how to add Helm validation to SDC onboarding

agreed to :

  • add a new deployed container running the validation service, that can
    • run multiple version of helm and test that the package is deployabe
    • stretch do linting
    • stretch provide feedback to user in SDC UI
  • target H release to add the basic functionality, add configuration data to existing AUTO.JSON loaded in SDC config maps (onboarding container reads this at startup)

Not enough time to complete, code is dark until next release,


New repo is being created under SDC project : https://gerrit.onap.org/r/admin/repos/sdc/sdc-helm-validator


Work in progress for I release


Call for Committers

Requesting active committers to apply for formal Committer's role

Fill the template under : Committer Promotion Request for [SDC]

Will review and request a vote from all current committers


Note the new repo for Helm has been contributed by Nokia team, and they are committers on that repo (sub repo)


2 New Committers proposal :

André Schmid : André Schmid - Committer Promotion Request for [SDC]

Michael Morris : Michael Morris - Committer Promotion Request for [SDC]

Will setup the vote this week


JIRA Updates

  • High priority defects
  • Open Reviews
  • Defects & tasks backlog
  • Current Release progress : H release
  • Others


High priority defects :

 

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Refresh

  • Other High priority ticket to discuss ?
  • Xue investigating SSL issue

Open Reviews :


New features review / Bug fixes for H release

closing Release, only some doc updates pending


oom reviews:

SDC 1.8.4 merged on OOM master


MASTER is moved to I release, RC1 currently being assessed


Gerrit REVIEW can proceed with auto test in verify job, now accepting changes for Istambul and/or refactoring

  • Reminder of merge conditions : Verify must pass AND tests must be provided for new features (SONAR metrics are important but can only be checked AFTER code is merged)

Important : for new features, please provide explanation of changes and API/UI/unit testing, it is also advised to present changes at SDC weekly

we have a plan to add SONAR test to the verify job, will work on this in the coming months


Defect & Tasks Backlog (no update this week):

 

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Refresh

 

  • Use the AID (Architecture integration document) SDC Data model also for new comers


Need some input for Marketting launch https://wiki.onap.org/x/FNULBQ

Release planning : SDC R8 Release Planning to close out, all tasks marked completed and JIRA Cleanup done


Documentation work pending


Others:


3 BP have been approved for H release :

  • up-to-date new dependencies (not transitive) - can contact seccom for guidance
  • Helm V3 (mostly for OOM)
  • CII badging improvements (use good crypto)

2 GR

  • no more use of python2 (deprecated) -#GR
  • java 11 -# GR


Important note to committers and code contributors : please make sure these are followed or your contribution will not be merged




Automated Rolling Upgrade and Data Migration

No Update this release (parking topic for later)


Support of automated upgrade from version X to version X+1


Needed for every change that breaks existing data validity : Have a strategy to handle data migration

  • Create a wiki page, details for every feature and its impact on data for migration / schema changes -  check the wiki page: Upgrade plan
    • Feature X: All services metadata must have new property Y
  • Implementing a "task" for migrating data accordingly.
    • Example: asdctool mig2002

SDC-3155 - Getting issue details... STATUS Epic created

→ Discuss further and create User stories along with Bell Canada, Amdocs, Tata communications

Will need to prioritize VS Guilin Requirements →

this may shift to next release due to low commitment

Learn from SDNC experience;

"Normatives" types: challenging


Important Jira tasks we need to pick up


Long Term tasks

INCREASE SONAR Coverage and lower SONAR bugs

We've noticed a growth of SONAR issues and coverage is getting lower,

https://sonarcloud.io/dashboard?id=onap_sdc

Stats are computed only on Merged code, it would be good for contributors to :

1) Enable Sonar plugins in IDE try to fix issues before they get in

2) To reduce issues, we could try and run through module per module (divide and conquer approach)

3) other ideas ?

4) Coverage has reached 55% !! thanks for your support ! Still need to keep an eye on it for future releases

  • Reduce line of codes (unused code)
  • Increase testing
  • Use LomBok to cover getter setter
  • You can see where coverage per module in sonar views

Other long term tasks

  • SDC-2708 Add assertions for unit tests  - #NewComers
  • SDC-2812Refactor all usage of Eithers - Guilin R7, #NewComers
  • SDC-2844 JUnit 5 unit test  - on going for new UT
  • SDC-3108 - Getting issue details... STATUS Migrate all TestNG tests to Junit5 , #NewComers



Security  - Guilin

Looking at these and this will significantly impact SDC APIs, since SDC does not have password it has to defer request to portal/aaf

exception for this in Guilin requested , though PORTAL provided Credentials validation API so that SDC can check users - will see if we have time to do something about these  

Only one left open OJSI 94, presented to SECCOM and they agreed on current progress

Parking this topic until further updates

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Refresh


Reviewing last week's action items

see below


Q&AIf you have time, pay attention to SDC mailing list questions
Istambul Requirements

New requirements for I release can be proposed, check with ArchSubcomittee and Usecase/req comittee


Release planning : Release Planning: Istanbul

M0 for Istambul is planned on April 1st


Release Requirements : Istanbul Release Requirements

Requirements impact per components : Istanbul Impact View per Component



Discuss SDC APIs and Swagger generation

Call happened last Wed,

We reviewed the current SDC APIs pictured in Architecture documentation and even if we believe the split makes sense, it seems that there are some mismatch with the current implementation and/or API locations, also Doc is incomplete

Decided to move forward to :

1) regroup APIs per Backend

2) enable Swagger doc generation (current one is a static copy that happened at one point ? not sure when)

3) annotations are there in the code so let's reuse them


thanks Michael for committing the fix, currently in review, will cherry pick this one to H release as it's documentation

Done, closing this item



Deletion of Old catalog entries

Ericsson would be interesting in progressing this item, Chris to check if Ofir has some old discussion around this


Still waiting answer from Ofir but found this in old meeting notes :

  • No delete properties in data types ( groups, capability type, policy, etc.). Reason – no versioning for data types
  • Only adding of new properties is supported
  • No change type of property ( like delete)
  • Properties can be deleted in node types – exist versioning
  • No delete “closed” resources. Only undo checkout operation.All non certified versions will be deleted automatically :
  • After certification all resources between 2 certified versions will be marked as deleted. Exist special task that will delete all marked as deleted components if no usage it as instance in another component.



size limitations in SDC

How is the community is handling big packages ? SDC limits at around 8meg

use ext ref in TOSCA.


No updates



Action Items ()

  • Chris to investigate discussions about deletion of old catalog entries
    • Waiting answer from Ofir, provided findings in Chris' Notes



NO CALL PLANNED ON APRIL 5TH : Easter Monday (cancel sent on SDC mailing list)


Slack Channel : #SDC on LFN ONAP.org Slack instance


SDC Dev lab on Windriver :


ssh ubuntu@10.12.6.10 (with onap key)

10.12.6.10 - LAb is installed with latest release (SDC 1.8.4) on helm 3 and K8s 1.19

 new wiki entry if you want to build a lab of your own : Deploy OOM and SDC (or ONAP) on a single VM with microk8s - Honolulu Setup


Recording

zoom_2.mp4


Chat