Date  

Meeting Logistics

DayTimeMeeting IDZoom LinkJoin by phone
Monday[sdc] Team ONAP3, Mon UTC 11:00 / China 19:00 / Eastern 06:00 / Pacific 03:00https://lists.onap.org/g/onap-meetings/calendarSee Groups.io calendar invite

See Groups.io Calendar Invite

Note that a Waiting room has been added to the meeting room, the host will let you join once identified

Meeting Attendees

Michael Morris

Anderson Ribeiro

Christophe Closset

Krupa Nagabhushan

Vasyl Razinkov

Xue Gao

Marine de Dorlodot

André Schmid

Gervais-Martial Ngueko

Agenda & Minutes

Review open action items from last week

AgendaMinutes (Draft to be updated during call)
Slides
Helm package verification

In Guilin, we decided to not do helm package validation/verification, several ideas were discussed at that time. Some improvements are planned for H release.

Presented by Nokia team to discuss how to add Helm validation to SDC onboarding

agreed to :

  • add a new deployed container running the validation service, that can
    • run multiple version of helm and test that the package is deployabe
    • stretch do linting
    • stretch provide feedback to user in SDC UI
  • target H release to add the basic functionality, add configuration data to existing AUTO.JSON loaded in SDC config maps (onboarding container reads this at startup)

Not enough time to complete, code is dark until next release,


New repo under SDC project :https://gerrit.onap.org/r/admin/repos/sdc/sdc-helm-validator


Work in progress for I release, OOM review Merged https://gerrit.onap.org/r/c/oom/+/119711


Discussed about adding integration tests for this in SDC-BE repo (to use SDC integration tests builds)

This requires to download LATEST images from external repo for Helm validator (as these are not built by SDC Main Maven Build)

Need to document and prepare a dedicated maven profile to inform people that they require additional containers to run the integration tests

Need to trigger automatically these tests in CI-Management to ensure a change in Helm validator does not break SDC maiin build

Can discuss offline with Christophe Closset


Next update integrating SDC-BE and Helm validator

Review merged: https://gerrit.onap.org/r/c/sdc/+/120762

Version 1.9.0 successfully passed gating


Discussed about adding integration tests for this in SDC-BE repo. 

Integration tests to be executed as part of the existing gerrit job. Version of helm validator to be fixed, with version updated as needs be. Normal review process, with the integration tests being executed in the verify job, will ensure new version does not break SDC build

Profile to support skipping of the helm validator test cases locally to avoid need to bring in external dependencies when executing locally.

 

Integration tests merged last week: https://gerrit.onap.org/r/c/sdc/+/121540

 

Completed - to be removed from agenda


Committers Update

Requesting active committers to apply for formal Committer's role

Fill the template under : Committer Promotion Request for [SDC]

Will review and request a vote from all current committers


JIRA Updates

  • High priority defects
  • Open Reviews
  • Defects & tasks backlog
  • Current Release progress : H release
  • Others


High priority defects :

 

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Loading...
Refresh

  • Other High priority ticket to discuss ?

Open Reviews :

H RELEASE SIGNED OFF by TSC on THUR 5/29

MASTER is moved to I release, H official public announcement to be made soon :

#AGREED the TSC approves the signoff of the Honolulu release with the public announcement to be made on May 11


Gerrit REVIEW can proceed with auto test in verify job, now accepting changes for Istanbul and/or refactoring

  • Reminder of merge conditions : Verify must pass AND tests must be provided for new features (SONAR metrics are important but can only be checked AFTER code is merged)

Important : for new features, please provide explanation of changes and API/UI/unit testing, it is also advised to present changes at SDC weekly

we have a plan to add SONAR test to the verify job, will work on this in the coming months


Defect & Tasks Backlog (no update this week):

 

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Loading...
Refresh

 

  • Use the AID (Architecture Integration DocumentSDC Data model also for new comers


Others:


3 new GR being reviewed for Istanbul and 1 BP :


  1. Promote to Global Requirement: CONTINUATION OF PACKAGES UPGRADES IN DIRECT DEPENDENCIES, SECCOM to provide recommendations

    Updates in progress : SDC-3572 - Getting issue details... STATUS

  1. Promote to Global Requirement: CONTINUATION OF CII BADGING SCORE IMPROVEMENTS FOR GOLD LEVEL, target is to reach silver level more info : CII Badging Program
  2. IPV4/V6 support : should be no issue for SDC (tested daily by Nokia Lab)
  3. Promote to Best Practice: LOGS MANAGEMENT - PHASE 1: COMMON PLACE FOR DATA → use STDOUT as output for logs in Logback conf as a first step


2 new Best Practices approved by TSC for Jakarta:

REQ-399 - Getting issue details... STATUS

REQ-396 - Getting issue details... STATUS



SDC performance issue

During H release Stability testing for SDC, it was noticed that performance decreases over time, up to the point where onboarding is not successful

Not had time to investigate logs yet but saw some exceptions happening

Test details and logs can be found here :

INT-1912 - Getting issue details... STATUS

 

Cassandra configuration changes in stability tests resulted in significant improvement with success rate in excess of 90%. Remaining failures are likely to be due to timing issues

Duration per request increases as DB becomes more loaded. 

Patchset to be pushed with new configuration and to expose configuration through helm charts to enable tunning where required.

Test results: https://logs.onap.org/onap-integration/weekly/onap_weekly_pod4_master/2021-06/28_21-34/stability/results_sdc_5_24h/onaptests_bench.html


Intermittent distribution failures in Gating

Intermittent failures in distribution causing Gating to fail. Was previously investigated, what is the current status?


Following issue reported during onboarding which can lead to distribution failures but the issue is in the onboarding: 

SDC-3508 - Getting issue details... STATUS

Suspected to be caused by consistency issue between cassandra nodes. Changes to consistent settings in cassandra has been suggested by Orange that may resolve this issue

 

Priority likely to be lowered, failures due to concurrent requests to cassandra 


Important Jira tasks we need to pick up


Long Term tasks

INCREASE SONAR Coverage and lower SONAR bugs

We've noticed a growth of SONAR issues and coverage is getting lower,

https://sonarcloud.io/dashboard?id=onap_sdc

Stats are computed only on Merged code, it would be good for contributors to :

1) Enable Sonar plugins in IDE try to fix issues before they get in

2) To reduce issues, we could try and run through module per module (divide and conquer approach)

3) other ideas ?

4) Coverage is back up to 55.0%

  • Reduce line of codes (unused code)
  • Increase testing
  • Use LomBok to cover getter setter
  • You can see where coverage per module in sonar views

Other long term tasks

  • SDC-2708 - Getting issue details... STATUS  Add assertions for unit tests  - #NewComers
  • SDC-2812 - Getting issue details... STATUS  Refactor all usage of Eithers - Guilin R7, #NewComers
  • SDC-2844 - Getting issue details... STATUS  JUnit 5 unit test  - on going for new UT



Security issues

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Loading...
Refresh

OJSI-94 - Getting issue details... STATUS

This issue significantly impact SDC APIs, since SDC does not have password and has to defer request to portal/aaf. PORTAL provides credentials validation API so that SDC can check users - will see if we have time to do something about these.

Changes presented to SECCOM and they agreed on current progress.

Parking this topic until further updates.

Exemption was previously requested from SECCOM. Solution may cause big impact in sdc-wfd-fe.

 

Xue Gao have confirmed this significantly impacts SDC, and the changes must be studied and planned properly.

Added as a risk in the Istanbul release as we do not have resources to commit in fixing the issue: Istanbul Risks.



sdc/utils/DmaapPublisher

What is this project/module for and where it is being used?

  • The project/module is not part of SDC build
  • It does not compile/build
    • First because of missing pom properties
    • After fixing the properties, because of a dependency, which does not exist
<dependency>
  <groupId>com.att.nsa</groupId>
  <artifactId>dmaapClient</artifactId>
  <version>0.2.16</version>
</dependency>

 

Planned to be removed today if there are no objections.

 

Removed, item closed


Intermittent Integration Tests

UI Tests  

Tooltip problem:


Unknown timeout exception: https://logs.onap.org/production/vex-yul-ecomp-jenkins-1/sdc-integration-tests-master-verify-java/650/integration-tests/target/ExtentReport/UI/SDC_UI_Extent_Report.html.gz


Startup  

sdc-backend-init error:

https://jenkins.onap.org/job/sdc-integration-tests-master-verify-java/670/console

[ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (docker-start-for-it) on project sdc-integration-tests: I/O Error: [onap/sdc-backend-init:latest] "sdc-backend-init": Container stopped with exit code 0 unexpectedly after 541089 ms while waiting on log out 'Chef Client finished' -> [Help 1]

Build issues

 

NPM / YARN issue:

https://jenkins.onap.org/job/sdc-integration-tests-master-verify-java/671/console

[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.8.0:install-node-and-yarn (install node and yarn) on project onboarding-fe: Could not extract the Node archive: Could not extract archive: '/home/jenkins/.m2/repository/com/github/eirslett/node/10.17.0/node-10.17.0-linux-x64.tar.gz': EOFException -> [Help 1]

 

Vasyl Razinkov has opened a ticket on LFN related to it: https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/IT-22249

There is a work in progress to update Node/NPM dependencies (Vasyl Razinkov):  SDC-3600 - Getting issue details... STATUS

 

Patchset merged in today, monitor result of patchset


Q&AIf you have time, pay attention to SDC mailing list and Slack channel questions


Action Items

  •  


Slack Channel: #SDC on LFN ONAP.org Slack instance (onapproject.slack.com)


SDC Dev lab on Windriver:

ssh ubuntu@10.12.6.10 (with onap key)

10.12.6.10 - LAb is installed with latest release (SDC 1.8.4) on helm 3 and K8s 1.19

 new wiki entry if you want to build a lab of your own : Deploy OOM and SDC (or ONAP) on a single VM with microk8s - Honolulu Setup


Recording

zoom_0.mp4

Chat

No chat log was produced during the meeting