Date  

Meeting Logistics

DayTimeMeeting IDZoom LinkJoin by phone
Monday[sdc] Team ONAP3, Mon UTC 11:00 / China 19:00 / Eastern 06:00 / Pacific 03:00https://lists.onap.org/g/onap-meetings/calendarSee Groups.io calendar invite

See Groups.io Calendar Invite

Note that a Waiting room has been added to the meeting room, the host will let you join once identified

Meeting Attendees

TBD - see recording

Agenda & Minutes

Review open action items from last week

AgendaMinutes (Draft to be updated during call)
Slides
Helm package verification

In Guilin, we decided to not do helm package validation/verification, several ideas were discussed at that time. Some improvements are planned for H release.

Presented by Nokia team to discuss how to add Helm validation to SDC onboarding

agreed to :

  • add a new deployed container running the validation service, that can
    • run multiple version of helm and test that the package is deployabe
    • stretch do linting
    • stretch provide feedback to user in SDC UI
  • target H release to add the basic functionality, add configuration data to existing AUTO.JSON loaded in SDC config maps (onboarding container reads this at startup)

Not enough time to complete, code is dark until next release,


New repo under SDC project :https://gerrit.onap.org/r/admin/repos/sdc/sdc-helm-validator


Work in progress for I release, OOM review in progress https://gerrit.onap.org/r/c/oom/+/119711


Removing HelmV2 support to comply with OOM comments, DONE - waiting approval from oom team


Discussed about adding integration tests for this in SDC-BE repo (to use SDC integration tests builds)

This requires to download LATEST images from external repo for Helm validator (as these are not built by SDC Main Maven Build)

Need to document and prepare a dedicated maven profile to inform people that they require additional containers to run the integration tests

Need to trigger automatically these tests in CI-Management to ensure a change in Helm validator does not break SDC maiin build

Can discuss offline with Christophe Closset


Next update integrating SDC-BE and Helm validator

Still in Progress


Committers Update

Requesting active committers to apply for formal Committer's role

Fill the template under : Committer Promotion Request for [SDC]

Will review and request a vote from all current committers



1 New committer, Approved by all current committers - Anderson Ribeiro - Committer Promotion Request for [SDC]

Congrats to Anderson! Welcome on board


INFO Yaml updated, TSC Acknowledged, Check gerrit groups to be sure all is ok



PTL Stepping down

Chris is going to step down as SDC PTL to work on other challenges.

Will start new PTL election after H release signoff, still plans to stay committer for the next release and help with transition.


JIRA Updates

  • High priority defects
  • Open Reviews
  • Defects & tasks backlog
  • Current Release progress : H release
  • Others


High priority defects :

 

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Loading...
Refresh

  • Other High priority ticket to discuss ?
  • Xue submitted a patch for the SSL issue,Verified on Windriver and merged

Open Reviews :

New features review / Bug fixes for H release


5 bugfixes merged on H release, new dockers released (1.8.5)


oom reviews: in gating : https://gerrit.onap.org/r/c/oom/+/120624

Merged on OOM Master, still in gating for H branch : https://gerrit.onap.org/r/c/oom/+/120834


Docs to be updated, reviews open but waiting to merge to be sure above patch is taken into account for H release otherwise these will be delivered in H maintenance build (planned in 3weeks)


MASTER is moved to I release, H should be released this week


Gerrit REVIEW can proceed with auto test in verify job, now accepting changes for Istambul and/or refactoring

  • Reminder of merge conditions : Verify must pass AND tests must be provided for new features (SONAR metrics are important but can only be checked AFTER code is merged)

Important : for new features, please provide explanation of changes and API/UI/unit testing, it is also advised to present changes at SDC weekly

we have a plan to add SONAR test to the verify job, will work on this in the coming months


Defect & Tasks Backlog (no update this week):

 

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Loading...
Refresh

 

  • Use the AID (Architecture integration documentSDC Data model also for new comers




Need some input for Marketting launch https://wiki.onap.org/x/FNULBQ

Release planning : SDC R8 Release Planning to close out, all tasks marked completed and JIRA Cleanup done


Documentation work completed, release note & Arch update done and merged on both branches


Others:


3 BP have been approved for H release :

  • up-to-date new dependencies (not transitive) - can contact seccom for guidance
  • Helm V3 (mostly for OOM)
  • CII badging improvements (use good crypto)

2 GR

  • no more use of python2 (deprecated) -#GR
  • java 11 -# GR


Important note to committers and code contributors : please make sure these are followed or your contribution will not be merged


2 new GR being reviewed for Istambul and 1 BP :


  1. Promote to Global Requirement: CONTINUATION OF PACKAGES UPGRADES IN DIRECT DEPENDENCIES, Seccom to provide recommendations
  2. Promote to Global Requirement: CONTINUATION OF CII BADGING SCORE IMPROVEMENTS FOR GOLD LEVEL
  3. IPV4/V6 support : should be no issue for SDC (tested daily by Nokia Lab)
  4. Promote to Best Practice: LOGS MANAGEMENT - PHASE 1: COMMON PLACE FOR DATA → use STDOUT as output for logs in Logback conf as a first step




SDC performance issue

During H release Stability testing for SDC, it was noticed that performance decreases over time, up to the point where onboarding is not successful

Not had time to investigate logs yet but saw some exceptions happening

Test details and logs can be found here :

INT-1912 - Getting issue details... STATUS


Automated Rolling Upgrade and Data Migration

No Update this release (parking topic for later)


Support of automated upgrade from version X to version X+1


Needed for every change that breaks existing data validity : Have a strategy to handle data migration

  • Create a wiki page, details for every feature and its impact on data for migration / schema changes -  check the wiki page: Upgrade plan
    • Feature X: All services metadata must have new property Y
  • Implementing a "task" for migrating data accordingly.
    • Example: asdctool mig2002

SDC-3155 - Getting issue details... STATUS Epic created

→ Discuss further and create User stories along with Bell Canada, Amdocs, Tata communications

Will need to prioritize VS Guilin Requirements →

this may shift to next release due to low commitment

Learn from SDNC experience;

"Normatives" types: challenging


Important Jira tasks we need to pick up


Long Term tasks

INCREASE SONAR Coverage and lower SONAR bugs

We've noticed a growth of SONAR issues and coverage is getting lower,

https://sonarcloud.io/dashboard?id=onap_sdc

Stats are computed only on Merged code, it would be good for contributors to :

1) Enable Sonar plugins in IDE try to fix issues before they get in

2) To reduce issues, we could try and run through module per module (divide and conquer approach)

3) other ideas ?

4) Coverage has reached 55% !! thanks for your support ! Still need to keep an eye on it for future releases

  • Reduce line of codes (unused code)
  • Increase testing
  • Use LomBok to cover getter setter
  • You can see where coverage per module in sonar views

Other long term tasks

  • SDC-2708 Add assertions for unit tests  - #NewComers
  • SDC-2812Refactor all usage of Eithers - Guilin R7, #NewComers
  • SDC-2844 JUnit 5 unit test  - on going for new UT
  • SDC-3108 - Getting issue details... STATUS Migrate all TestNG tests to Junit5 , #NewComers



Security  - Guilin

Looking at these and this will significantly impact SDC APIs, since SDC does not have password it has to defer request to portal/aaf

exception for this in Guilin requested , though PORTAL provided Credentials validation API so that SDC can check users - will see if we have time to do something about these  

Only one left open OJSI 94, presented to SECCOM and they agreed on current progress

Parking this topic until further updates

T Key Summary Assignee Reporter P Status Resolution Created Updated Due
Loading...
Refresh


Istambul Requirements

New requirements for I release can be proposed, check with ArchSubcomittee and Usecase/req comittee


Release planning : Release Planning: Istanbul

Release Requirements : Istanbul Release Requirements

Requirements impact per components : Istanbul Impact View per Component



size limitations in SDC

How is the community is handling big packages ? SDC limits at around 8meg

use ext ref in TOSCA.


Discussions happened on this at CNF meeting, it seems some vendors do provide full images within their onboarding package (instead of referring to external repositories). Not sure what is the best plan here, should SDC decouple the image and store that somewhere ? this requires more design



Reviewing last week's action items

see below


Q&AIf you have time, pay attention to SDC mailing list questions
New Feature Proposal

To be started in I release

Presentation from Michael Morris about introducing a model type in SDC to allow the support of multiple models/variants, presentation to happen this week at Arch meeting.



Action Items ()

  • None


Slack Channel : #SDC on LFN ONAP.org Slack instance


SDC Dev lab on Windriver :


ssh ubuntu@10.12.6.10 (with onap key)

10.12.6.10 - LAb is installed with latest release (SDC 1.8.4) on helm 3 and K8s 1.19

 new wiki entry if you want to build a lab of your own : Deploy OOM and SDC (or ONAP) on a single VM with microk8s - Honolulu Setup


Recording

zoom_0.mp4

Chat